fix(normalize-color): require full-string match for rgb/hsl/hwb - #58496
Open
scs0209 wants to merge 1 commit into
Open
fix(normalize-color): require full-string match for rgb/hsl/hwb#58496scs0209 wants to merge 1 commit into
scs0209 wants to merge 1 commit into
Conversation
Functional color regexes lacked ^/$, so junk around a valid rgb()/hsl()/hwb() substring was accepted while hex forms already required a full match.
This was referenced Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@react-native/normalize-colorsanchors hex color forms with^/$, butrgb/rgba/hsl/hsla/hwbmatchers did not. BecauseRegExp.prototype.execfinds a substring match, strings likexxrgb(1, 2, 3)yyorrgba(1,2,3,0.5)extrawere accepted and normalized.That is inconsistent with hex handling (
#fff/#fffalready returnnull) and with treating the whole input as a single color token.Fixes #58495
Changelog
[GENERAL] [FIXED] - Reject functional color strings that only partially match rgb/hsl/hwb
Test Plan
yarn test packages/normalize-color/__tests__/normalizeColor-test.jsAll 14 tests pass. Added cases for leading/trailing junk around
rgb/rgba/hsl/hwb.Minimal repro (before fix):
Made with Cursor